Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect directory of intrinsic.rs generated. (#332) #336

Merged
merged 2 commits into from
Oct 27, 2023
Merged

fix: incorrect directory of intrinsic.rs generated. (#332) #336

merged 2 commits into from
Oct 27, 2023

Conversation

mutalisk999
Copy link
Contributor

What ❔

Fix: incorrect directory of intrinsic.rs generated. (#332)

change

fn update_rust_system_constants(intrinsic_gas_constants: &IntrinsicSystemGasConstants) {
    let rust_fee_constants = generate_rust_fee_constants(intrinsic_gas_constants);
    save_file(
        "core/lib/config/src/constants/fees/intrinsic.rs",
        rust_fee_constants,
    );
}

to

fn update_rust_system_constants(intrinsic_gas_constants: &IntrinsicSystemGasConstants) {
    let rust_fee_constants = generate_rust_fee_constants(intrinsic_gas_constants);
    save_file(
        "core/lib/constants/src/fees/intrinsic.rs",
        rust_fee_constants,
    );
}

Why ❔

File intrinsic.rs is generated to dir core/lib/constants/src/fees.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@mutalisk999
Update main.rs
e986483 
fix the incorrect intrinsic.rs directory.
@mutalisk999 mutalisk999 requested a review from a team as a code owner October 27, 2023 09:26
popzxc
popzxc approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mutalisk999 mutalisk999 mentioned this pull request Oct 27, 2023
Closed
@popzxc popzxc enabled auto-merge October 27, 2023 09:28
@popzxc popzxc added this pull request to the merge queue Oct 27, 2023
Merged via the queue into matter-labs:main with commit eefaad0 Oct 27, 2023
21 checks passed
@zksync-era-bot zksync-era-bot mentioned this pull request Oct 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2023
@zksync-era-bot @perekopskiy
chore(main): release core 17.1.0 (#337)
ba88f67 
🤖 I have created a release *beep* *boop*
---


##
[17.1.0](core-v16.2.0...core-v17.1.0)
(2023-11-03)


### ⚠ BREAKING CHANGES

* Update to protocol version 17
([#384](#384))

### Features

* **en:** Cache blocks in `fetch_l2_block`
([#403](#403))
([b94c845](b94c845))
* Port boojum eth-sender changes
([#293](#293))
([8027326](8027326))
* **state-keeper:** Disable some seal criteria for boojum
([#390](#390))
([2343532](2343532))
* Update to protocol version 17
([#384](#384))
([ba271a5](ba271a5))
* **vm:** Make calculation for pubdata a bit more percise
([#392](#392))
([6d0e61c](6d0e61c))


### Bug Fixes

* bump zksolc from yanked version to 1.3.16
([#348](#348))
([c32b88f](c32b88f))
* **db-index:** Add missing index from FRI prover jobs
([#334](#334))
([730447f](730447f))
* **db-query:** use join instead of nested query for FRI prover
extracting
([#364](#364))
([f9cc831](f9cc831))
* **db-query:** use nested query for requeuing FRI prover jobs
([#399](#399))
([3890542](3890542))
* incorrect directory of intrinsic.rs generated.
([#332](#332))
([#336](#336))
([eefaad0](eefaad0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: perekopskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutalisk999 @popzxc